Skip to content

fix loading style in socialicon#52

Merged
flyingcircle merged 3 commits intoreact-native-elements:masterfrom
ankushdutt:socialicon-loadingfix
Dec 23, 2021
Merged

fix loading style in socialicon#52
flyingcircle merged 3 commits intoreact-native-elements:masterfrom
ankushdutt:socialicon-loadingfix

Conversation

@ankushdutt
Copy link
Contributor

@ankushdutt ankushdutt commented Mar 13, 2021

fixes #51

image

@netlify
Copy link

netlify bot commented Mar 13, 2021 •
edited
Loading

Deploy preview for rne-playground ready!

Built with commit c5a3207

https://deploy-preview-52--rne-playground.netlify.app

Uyadav207
Uyadav207 reviewed Mar 13, 2021
View reviewed changes
Copy link
Contributor

@Uyadav207 Uyadav207 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-03-13 16-25-00

Problem

  • The icon still shows beside the loading icon.
  • when onLoading: {true} && icon: {true} then icon and blank svg img is visible.

Possible Solution

  • please try to use Conditional Rendering.
  • This can be done using a ternary operator.

@ankushdutt
Copy link
Contributor Author

ankushdutt commented Mar 13, 2021

fixed the loading issue here (react-native-elements/react-native-elements#2846)
Added the activityIndicatorStyle for socialicons to the playground here, so we can merge this one too
@pranshuchittora

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 19, 2021

@ankushdutt thanks for finding the issue and fixing the same in the core.
Is activityIndicatorStyle is a new prop ?

If yes, then pls add the same to the docs (https://github.com/react-native-elements/react-native-elements/tree/next/website/docs/props) so that it can be automatically pulled in the Playground via #15

@ankushdutt
Copy link
Contributor Author

ankushdutt commented Mar 20, 2021 •
edited
Loading

Is activityIndicatorStyle is a new prop ?

No, it was already present in the codebase of React Native Elements Core (I haven't added them in my fix there). Though, its not present in SocialIcon docs

Alright, I'll make a PR for the missing props in the core.

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 26, 2021

Did you made a PR for the activityIndicatorStyle

@ankushdutt
Copy link
Contributor Author

ankushdutt commented Apr 5, 2021

Did you made a PR for the activityIndicatorStyle

Yes, here: react-native-elements/react-native-elements#2946

@flyingcircle flyingcircle merged commit eedf299 into react-native-elements:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Uyadav207 Uyadav207 Uyadav207 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SocialIcon: original icon is visible when loading

4 participants

@ankushdutt @pranshuchittora @Uyadav207 @flyingcircle